Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure shift + 7 shortcut to focus search field works #22073

Merged
merged 1 commit into from
Apr 25, 2023
Merged

fix: make sure shift + 7 shortcut to focus search field works #22073

merged 1 commit into from
Apr 25, 2023

Conversation

filiptammergard
Copy link
Contributor

Closes #22072

What I did

Due to problem described in issue, shortcut doesn't match. With startsWith it does match, which makes the shortcut work again.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic self-assigned this Apr 17, 2023
@valentinpalkovic valentinpalkovic added bug ui patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 17, 2023
@valentinpalkovic valentinpalkovic self-requested a review April 17, 2023 14:39
@valentinpalkovic valentinpalkovic merged commit d95c620 into storybookjs:next Apr 25, 2023
@shilman shilman mentioned this pull request Apr 25, 2023
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 3, 2023
shilman pushed a commit that referenced this pull request May 3, 2023
@valentinpalkovic @shilman
Merge pull request #22073 from filiptammergard/shortcut
546d8bc 
fix: make sure shift + 7 shortcut to focus search field works
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinpalkovic valentinpalkovic valentinpalkovic approved these changes

Assignees

@valentinpalkovic valentinpalkovic

Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: / shortcut to focus search field doesn't work
3 participants
@filiptammergard @valentinpalkovic @shilman