Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add platform-specific null piping for stderr for npm list command #21947

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Add platform-specific null piping for stderr for npm list command #21947

merged 1 commit into from
Apr 5, 2023

Conversation

valentinpalkovic
Copy link
Contributor

Closes #21872

What I did

Add platform-specific null piping for stderr for npm list command

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic added bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 5, 2023
@valentinpalkovic valentinpalkovic self-assigned this Apr 5, 2023
@ndelangen ndelangen merged commit 29ea8a8 into next Apr 5, 2023
@ndelangen ndelangen deleted the valentin/fix-npm-ls-unexpected-error-thrown branch April 5, 2023 12:53
This was referenced Apr 5, 2023
Closed
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 6, 2023
shilman pushed a commit that referenced this pull request Apr 6, 2023
@ndelangen @shilman
Merge pull request #21947 from storybookjs/valentin/fix-npm-ls-unexpe…
3a16e05 
…cted-error-thrown

Add platform-specific null piping for stderr for npm list command
@shilman shilman mentioned this pull request Apr 6, 2023
Merged
4 tasks
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees

@valentinpalkovic valentinpalkovic

Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: npx sb@next upgrade --prerelease fails
3 participants
@valentinpalkovic @ndelangen @shilman