Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Fix components disappearing on docs page on property change #21944

Conversation

valentinpalkovic
Copy link
Contributor

Closes #21894

What I did

Refactor AbstractRenderer to use a Map instead of a Set for tracking application references, and add support for resetting applications for a specific DOM node in resetApplications().

How to test

  1. Run an Angular sandbox
  2. Open Storybook in your browser
  3. Access autogenerated button doc and change some properties. The rendered stories at the bottom shouldn't disappear.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic added bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 5, 2023
@valentinpalkovic valentinpalkovic self-assigned this Apr 5, 2023
@valentinpalkovic valentinpalkovic requested a review from Marklb April 5, 2023 09:16
…application references, and add support for resetting applications for a specific DOM node in resetApplications().
@valentinpalkovic valentinpalkovic force-pushed the valentin/fix-angular-disappearing-stories-on-docs-page branch from 6d5893b to 9204e55 Compare April 5, 2023 11:15
@shilman shilman added the angular label Apr 5, 2023
@shilman shilman changed the title Fix Angular components disappearing on docs page on property change Angular: Fix components disappearing on docs page on property change Apr 5, 2023
Copy link
Contributor

@sheriffMoose sheriffMoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valentinpalkovic great work 👍

@valentinpalkovic valentinpalkovic merged commit e8bca87 into next Apr 5, 2023
@valentinpalkovic valentinpalkovic deleted the valentin/fix-angular-disappearing-stories-on-docs-page branch April 5, 2023 13:01
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 6, 2023
shilman pushed a commit that referenced this pull request Apr 6, 2023
…pearing-stories-on-docs-page

Angular: Fix components disappearing on docs page on property change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The docs page does not update correctly when changing controls
3 participants