Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: make the CI config ready for 7.0 release #21808

Merged
merged 10 commits into from
Apr 3, 2023
Merged

Build: make the CI config ready for 7.0 release #21808

merged 10 commits into from
Apr 3, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Mar 29, 2023 •
edited
Loading

Closes #21784

  • Rename generate-repros to generate-sandboxes
  • Split generate-sandbox into generate-sandbox-main & generate-sandbox-next (these can be manually triggered)
  • Cleanup the generate-sandbox-* workflows
  • Make sb sandbox command in CLI use main as default branch
  • Extract common paths into a constants file to ensure consistency
  • Rename scripts/sandbox-generators to scripts/sandbox

@ndelangen
make main default branch for sandboxes
246a7ef
@ndelangen
split generate workflow into main and next
76f05c7 
skip yarn command for publish
add branch parameter for publish script
drop next parameter for publish script
add a constants file for scripts to prevent mismatching paths etc.
@ndelangen ndelangen self-assigned this Mar 29, 2023
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Mar 29, 2023
@ndelangen ndelangen changed the title Build: make the Ci config ready for 7.0 release Build: make the CI config ready for 7.0 release Mar 29, 2023
@ndelangen ndelangen requested review from yannbf and shilman March 29, 2023 10:50
yannbf
yannbf reviewed Mar 29, 2023
View reviewed changes
generate-sandboxes.sh Outdated Show resolved Hide resolved
yannbf
yannbf reviewed Mar 29, 2023
View reviewed changes
scripts/tasks/publish.ts Outdated Show resolved Hide resolved
@shilman shilman marked this pull request as ready for review April 3, 2023 12:56
yannbf
yannbf approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@yannbf yannbf merged commit c31eb03 into next Apr 3, 2023
@yannbf yannbf deleted the norbert/ci-ready-for-release branch April 3, 2023 13:58
@shilman shilman mentioned this pull request Apr 5, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

@shilman shilman Awaiting requested review from shilman

Assignees

@ndelangen ndelangen

Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ecosystem CI for main branch
2 participants
@ndelangen @yannbf