Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve blocks error messages #21615

Merged
merged 3 commits into from
Mar 16, 2023
Merged

improve blocks error messages #21615

merged 3 commits into from
Mar 16, 2023

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Mar 15, 2023 •
edited
Loading

Works on #20496

Related PRs to MDX CSF repos:

storybookjs/mdx1-csf#21
storybookjs/mdx2-csf#37

What I did

This PR improves error messages when the of props for blocks is not correct.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@JReinhold JReinhold linked an issue Mar 15, 2023 that may be closed by this pull request
Meta/Story of not available in .stories.mdx files #20496
Closed
@JReinhold JReinhold added maintenance User-facing maintenance tasks mdx labels Mar 15, 2023
@JReinhold JReinhold requested a review from shilman March 15, 2023 09:57
@JReinhold JReinhold marked this pull request as ready for review March 15, 2023 09:58
shilman
shilman approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonniebigodes jonniebigodes mentioned this pull request Mar 15, 2023
Closed
@JReinhold JReinhold merged commit 8d1b3b8 into next Mar 16, 2023
@JReinhold JReinhold deleted the 20496-metastory-of-not-available-in-storiesmdx-files branch March 16, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks mdx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meta/Story of not available in .stories.mdx files
2 participants
@JReinhold @shilman