Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow vue files in importfn #21550

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

tobiasdiez
Copy link
Contributor

@tobiasdiez tobiasdiez commented Mar 10, 2023

What I did

If one uses https://github.com/tobiasdiez/storybook-vue-addon/ (which enables stories in native vue format), then one get warnings of the form

Cannot process .vue file with storyStoreV7: src/components/Button.stories.vue

This is fixed by allowing vue files.

How to test

I've noticed this issue in the context of tobiasdiez/storybook-vue-addon#38 (run pnpm example:vite)

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely not a scalable API, but until we come up with something better, it's what we can do.

For anyone else, see related #20442

@JReinhold JReinhold merged commit 351dbb6 into storybookjs:next Mar 16, 2023
@tobiasdiez tobiasdiez deleted the patch-2 branch March 17, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants