Vite: Update sandbox template for vue2 script #20750
Conversation
| // preferring community bootstrap scripts / generators instead. | ||
| script: | ||
| 'yarn create vite . --template vanilla && yarn add --dev @vitejs/plugin-vue2 vue-template-compiler vue@2 && echo "import vue2 from \'@vitejs/plugin-vue2\';\n\nexport default {\n\tplugins: [vue2()]\n};" > vite.config.js', | ||
| script: 'npx create-vue@2 {{beforeDir}} --default', |
There was a problem hiding this comment.
Based on https://github.com/vuejs/create-vue, it looks like we could also use npm create vue@3, right? Especially since SB7 does not support IE.
There was a problem hiding this comment.
I guess it's unclear to me based on that readme whether that's the version of the creator or the version of vue that will be installed. It only mentions IE support as the difference between the two. I think that to create a vue3 project, npm create vite is used instead.
There was a problem hiding this comment.
@IanVS with create-vue@3 it does generate a Vue3 Vite project:
{
"scripts": {
"dev": "vite",
"build": "vite build",
"preview": "vite preview"
},
"dependencies": {
"vue": "^3.2.45"
},
"devDependencies": {
"@vitejs/plugin-vue": "^4.0.0",
"vite": "^4.0.0"
}
}
The docs states:
Or, if you need to support IE11, you can create a Vue 2 project with
yannbf
added
vue
build
…se-official-vue2/vite-script
|
@yannbf Do i need to re-commit with |
|
@fazulk we'll need to change that flag once this is merged and https://github.com/storybookjs/sandboxes is updated based on the change you're making. It's a very clunky, round-about way of generating sandbox templates, and hopefully we can clean it up sometime. |
…script-to-use-official-vue2/vite-script
|
\o/ We're green! |
IanVS
changed the title
Issue: #20748
What I did
Update the Vue2/Vite loading script to use the official vue package.
How to test
yarn task --task dev --start-from=install --template vue2-vite/2.7-jsChecklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]