Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add prop-types dependency if not using TypeScript #20449

Merged
merged 2 commits into from
Dec 31, 2022
Merged

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Dec 30, 2022

Issue:

We haven't been adding prop-types to React JS projects, even though the example components use it. This breaks in yarn pnp and pnpm.

What I did

If the detected language is JavaScript (not TypeScript), we'll add prop-types to the dependencies that are installed during storybook init.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this!

code/lib/cli/src/generators/REACT/index.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants