CLI: Add prop-types dependency if not using TypeScript #20449
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
We haven't been adding
prop-types
to React JS projects, even though the example components use it. This breaks in yarn pnp and pnpm.What I did
If the detected language is JavaScript (not TypeScript), we'll add
prop-types
to the dependencies that are installed during storybook init.How to test
If your answer is yes to any of these, please make sure to include it in your PR.