CLI: Use correct package manager for automigrate #20428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #17870
What I did
My previous PR, #19425, introduced a
--package-manageroption to the CLI, but it missed handling the option in automigrate when run directly (vs as part ofinit). This fixes it so that runningnpx sb@next automigrate --package-manager=npm(or the deprecated way,npx sb@next automigrate --use-npm) works correctly.How to test
We have some unit tests, but they don't cover
automigrate()itself. I tested by creating a project, adding storybook, adding eslint and aneslintrc.jsfile, building the changes here in this branch, copying over thedistfile into the project, and runningnpx storybook@next automigrate --use-npm eslintPlugin