Build: bundle script a bit less repetitive, add a completion indicator #20277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
changed the title
tmeasday
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #20157
What I did
I was trying to come up with strategies to make the linked issue work, and in order to do so I needed to add a few extentions to the bundle script.
In the end I didn't make those extentions, but the cleanup I did to get there is still nice, I think.
This does add the option of ONLY generating mjs or ONLY generating cjs.
(it does not add the ability to swap extentions (I removed that after the experiment)
@yannbf you'll like this:
The bundle script now prints "done" after running successfully 😘