Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Split sb-scripts into two different migrations #20223

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Dec 13, 2022

Issue: N/A

What I did

This PR changes the sb-scripts migration into two migrations:

  • One that takes care of sb binaries
  • Another that takes care of sb scripts

This way each migration is more focused, and they can happen independently of each other

Additionally, the sb binaries migration will make sure that sb is removed and users always use storybook instead. The usage of sb in scripts is also updated to storybook.

Use cases

sb-binary: User does not have storybook - it's installed

image

sb-binary: User has storybook lib but also sb - sb is removed

image

sb-binary: User does not have storybook and does have sb - storybook is installed and sb is removed

image

sb-scripts: Scripts are updated and sb becomes storybook

image

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

- One that takes care of sb binaries
- Another that takes care of sb scripts
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yannbf in your last image, what is storybook build build? that looks like a bug?

@yannbf
Copy link
Member Author

yannbf commented Dec 13, 2022

@yannbf in your last image, what is storybook build build? that looks like a bug?

No, I just noticed that the repo I used to test this had "build-storybook": "storybook-build build". Problem is on my end! The tests are correct and would have picked that issue

Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @yannbf

@shilman shilman changed the title CLI: split sb-scripts into two different migrations CLI: plit sb-scripts into two different migrations Dec 13, 2022
@shilman shilman changed the title CLI: plit sb-scripts into two different migrations CLI: Split sb-scripts into two different migrations Dec 13, 2022
@shilman shilman merged commit 3db1a9d into next Dec 13, 2022
@shilman shilman deleted the fix/split-sb-scripts-automigration branch December 13, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants