-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade loader-utils to 2.0.4 in storysource and source-loader #19891
Upgrade loader-utils to 2.0.4 in storysource and source-loader #19891
Conversation
… to resolve a critical security issue found by npm audit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for being on top of this!
We should change this to version 2.0.4
instead of 2.0.3
, and run yarn install
in both packages to ensure yarn.lock
s are also being re-generated.
… to fix the security vulnerability
@shilman this should be patched to 6.5 ? |
@ndelangen this is already targeting the |
|
@bnussman-akamai there are lots of security issues with webpack4. if you're concerned, please upgrade to the latest prerelease which gets rid of webpack4 entirely and handles all known npm audit issues.
WIP migration guide here https://chromatic-ui.notion.site/Storybook-7-migration-guide-dbf41fa347304eb2a5e9c69b34503937 |
… to resolve a critical security issue found by npm audit
I just upgraded the versions of the loader utils in source-loader and storysource to resolve the security finding from the npm audit
Issue: critical security vulnerability in the loader-utils
What I did
Upgraded the loader-utils to 2.0.4 in storysource and source-loader
How to test
loader-utils 2.0.0 - 2.0.3 || 3.0.0 - 3.2.0
Severity: critical
Prototype pollution in webpack loader-utils - GHSA-76p3-8jx3-jpfq
loader-utils is vulnerable to Regular Expression Denial of Service (ReDoS) via url variable - GHSA-3rfm-jhwj-7488
loader-utils is vulnerable to Regular Expression Denial of Service (ReDoS) via url variable - GHSA-3rfm-jhwj-7488
loader-utils is vulnerable to Regular Expression Denial of Service (ReDoS) - GHSA-hhq3-ff78-jv3g
loader-utils is vulnerable to Regular Expression Denial of Service (ReDoS) - GHSA-hhq3-ff78-jv3g
fix available via
npm audit fix
node_modules/@storybook/addon-storysource/node_modules/loader-utils
node_modules/@storybook/angular/node_modules/loader-utils
node_modules/@storybook/builder-webpack5/node_modules/loader-utils
node_modules/@storybook/manager-webpack5/node_modules/loader-utils
node_modules/adjust-sourcemap-loader/node_modules/loader-utils
node_modules/babel-loader/node_modules/loader-utils
node_modules/loader-utils
node_modules/resolve-url-loader/node_modules/loader-utils
node_modules/style-loader/node_modules/loader-utils
node_modules/ts-loader/node_modules/loader-utils
If your answer is yes to any of these, please make sure to include it in your PR.
To @maintainers, I would like this to be patched for 6.5.13 versions.
Although this issue might have been fixed for 7-next, since there is no stable version 7, I need to have 6.5.14 as a stable version.