NextJS: Fix out-of-the-box babel handling #19842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
changed the title
valentinpalkovic
added
feature request
ci:merged
valentinpalkovic
force-pushed
the
valentin/swc-babel-nextjs
branch
3 times, most recently
from
b9c0d60 to
8aa2633
Compare
valentinpalkovic
force-pushed
the
valentin/swc-babel-nextjs
branch
from
ef4d668 to
44e8a6f
Compare
NextJS projects should work out-of-the-box when Storybook is initialized. 1. Scenario: .babelrc or project babel.config.(m)js(x) file doesn't exist In this case Next.js >= 12 uses swc to transpile the code. In Storybook we will still use babel to transpile the code. We use the preset `next/babel` and configure it to make the Next.js project work with Storybook. Any SWC/Next compiler related options are ignored 2. Scenario: .babelrc or project babel.config.(m)js(x) file exist Storybook will use the project's babel configuration for transpiling. All options, which are passed to the `next/babel` prest are respected.
valentinpalkovic
force-pushed
the
valentin/swc-babel-nextjs
branch
from
44e8a6f to
5c09970
Compare
shilman
changed the title
shilman
changed the title
shilman
reviewed
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
NextJS projects should work out-of-the-box when Storybook is initialized.
In this case Next.js >= 12 uses swc to transpile the code. In Storybook
we will still use babel to transpile the code. We use the preset
next/babeland configure it to make the Next.js project work with Storybook. Any SWC/Next compiler
related options are ignored
Storybook will use the project's babel configuration for transpiling. All options, which
are passed to the
next/babelprest are respected.