Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and include @storybook/blocks in standalone Storybook #19615

Merged
merged 8 commits into from
Oct 25, 2022

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Oct 25, 2022

Telescoping PR on top of #19598

This PR moves the @storybook/blocks package to code/ui/, includes it in the standalone Storybook and cleans up that whole Storybook a bit.

Most of the existing stories were unnecessary nested which didn't add any value to the Storybook. Here's the final sidebar:
image

@JReinhold JReinhold changed the base branch from next to jeppe/sb-604-create-a-standalone-storybook-for-our-phase-2 October 25, 2022 05:43
@JReinhold JReinhold self-assigned this Oct 25, 2022
@JReinhold JReinhold added the build Internal-facing build tooling & test updates label Oct 25, 2022
code/ui/.storybook/main.ts Outdated Show resolved Hide resolved
@JReinhold JReinhold marked this pull request as ready for review October 25, 2022 06:21
@JReinhold JReinhold requested a review from a team October 25, 2022 06:23
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (same qn about Chromatic)

code/ui/.storybook/main.ts Outdated Show resolved Hide resolved
Base automatically changed from jeppe/sb-604-create-a-standalone-storybook-for-our-phase-2 to next October 25, 2022 08:20
@JReinhold JReinhold merged commit 417de3f into next Oct 25, 2022
@JReinhold JReinhold deleted the jeppe/sb-604-doc-blocks-in-sb-for-sb branch October 25, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants