-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move and include @storybook/blocks
in standalone Storybook
#19615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-2' of github.com:storybookjs/storybook into jeppe/sb-604-doc-blocks-in-sb-for-sb
JReinhold
changed the base branch from
next
to
jeppe/sb-604-create-a-standalone-storybook-for-our-phase-2
October 25, 2022 05:43
JReinhold
commented
Oct 25, 2022
tmeasday
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (same qn about Chromatic)
Base automatically changed from
jeppe/sb-604-create-a-standalone-storybook-for-our-phase-2
to
next
October 25, 2022 08:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescoping PR on top of #19598
This PR moves the
@storybook/blocks
package tocode/ui/
, includes it in the standalone Storybook and cleans up that whole Storybook a bit.Most of the existing stories were unnecessary nested which didn't add any value to the Storybook. Here's the final sidebar: