Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade chromatic #19468

Merged
merged 1 commit into from
Oct 13, 2022
Merged

upgrade chromatic #19468

merged 1 commit into from
Oct 13, 2022

Conversation

ndelangen
Copy link
Member

upgrade chromatic cli

@ndelangen ndelangen self-assigned this Oct 13, 2022
@ndelangen ndelangen requested a review from ghengeveld October 13, 2022 07:49
@ndelangen
Copy link
Member Author

@ghengeveld I'm upgrading this because we keep seeing this happening:
https://app.circleci.com/pipelines/github/storybookjs/storybook/30234/workflows/07fd26a0-ed49-47e8-8ad6-672792cb9f77/jobs/425258

Like it happens on maybe 1/20 PRs/runs.

Maybe upgrading will help?
if not, can you give advice?

Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is going to solve your issue, but upgrading is a good idea nonetheless.

Here's what I see in the logs:

An error occurred while executing: 
`npx chromatic
  --exit-zero-on-changes
  --storybook-build-dir=/tmp/storybook/sandbox/angular-cli-13-ts/storybook-static
  --junit-report=/tmp/storybook/code/test-results/chromatic.xml
  --projectToken=undefined`

(Added newlines for readability)

This is some other tool invoking Chromatic, and the token is already undefined at this point, so I don't think the issue is in Chromatic.

@ndelangen ndelangen merged commit 25ac315 into next Oct 13, 2022
@ndelangen ndelangen deleted the tech/upgrade-chromatic branch October 13, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants