Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Exclude @storybook/testing-react from outdated check #19272

Merged
merged 4 commits into from
Oct 5, 2022
Merged

CLI: Exclude @storybook/testing-react from outdated check #19272

merged 4 commits into from
Oct 5, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Sep 27, 2022

Issue: N/A

What I did

This avoids an error message when upgrading storybook:

WARN Found 1 outdated packages (relative to '@storybook/[email protected]')
WARN Please make sure your packages are updated to ensure a consistent experience.
WARN - @storybook/[email protected]

I added @storybook/testing-react to the list of non-core packages, and also sorted the list, because it makes my brain feel better that way.

@IanVS IanVS changed the title Exclude @storybook/testing-react from outdated check CLI: Exclude @storybook/testing-react from outdated check Sep 27, 2022
@IanVS IanVS requested a review from yannbf October 3, 2022 16:24
@IanVS
Copy link
Member Author

IanVS commented Oct 4, 2022

@yannbf this is ready for review.

@IanVS IanVS requested a review from shilman October 5, 2022 12:25
@ndelangen ndelangen merged commit 27e2862 into next Oct 5, 2022
@ndelangen ndelangen deleted the testing-react-exclude-core branch October 5, 2022 13:26
@ndelangen ndelangen self-assigned this Oct 5, 2022
@IanVS
Copy link
Member Author

IanVS commented Oct 5, 2022

I still get the warning when using 7.0.0-alpha.35:

WARN Found 1 outdated packages (relative to '@storybook/[email protected]')
WARN Please make sure your packages are updated to ensure a consistent experience.
WARN - @storybook/[email protected]

Anyone have an idea why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@yannbf yannbf Awaiting requested review from yannbf

@shilman shilman Awaiting requested review from shilman

Assignees

@ndelangen ndelangen

Labels
bug cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanVS @ndelangen