Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-links: Move stories into addon #19124

Merged
merged 9 commits into from
Sep 12, 2022
Merged

Addon-links: Move stories into addon #19124

merged 9 commits into from
Sep 12, 2022

Conversation

ndelangen
Copy link
Member

  • add generic stories for addon-links in code/addons/links/template/stories
  • remove stories for links everywhere else

@ndelangen
remove all references to addon-links in examples
0207731 
create renderer agnostic stories in addons/links/template/stories
@ndelangen ndelangen changed the base branch from next to norbert/sb-574-addon-a11y September 7, 2022 10:11
@ndelangen ndelangen requested a review from shilman September 7, 2022 10:11
@ndelangen ndelangen self-assigned this Sep 7, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Sep 7, 2022
@ndelangen
Copy link
Member Author

I do not know how to test @storybook/addon-links/react because it's obviously going to be renderer specific.

tmeasday
tmeasday requested changes Sep 12, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the react functionality: we decided we might add a mechanism for addons to define framework specific stories in the future, but for now, just put them in renderers/<renderer>/template/stories/<addon>

code/addons/links/template/stories/parameters.stories.ts Outdated Show resolved Hide resolved
Base automatically changed from norbert/sb-574-addon-a11y to next September 12, 2022 16:05
@ndelangen ndelangen merged commit 19d75f0 into next Sep 12, 2022
@ndelangen ndelangen deleted the norbert/sb-577-addon-links branch September 12, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday requested changes

@shilman shilman Awaiting requested review from shilman

Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @tmeasday