-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameter, loader and decorator stories to lib/store
#19105
Conversation
And use in loaders/parameters stories
…oaders-parameters
@IanVS what is the "cwd" in a vite build? In this PR I add: config: ["../../code/lib/store/template/stories/preview.ts"], To the |
I think I'm missing a little context because I can't access linear. What is the reason for this PR? I'll take a look and see if I can figure out what's going on with vite. CWD should not be anything special in Vite, it's just where the command is run. |
@IanVS we are in the process of converting all stories from the existing examples (e.g. In these examples that test core stuff, we'd like to add project-level annotations (parameters, etc) to test the inheritance works properly. So we wanted to add the ability to define a "config" file for any package (the store, or an addon) that defines stories for a sandbox (in a
That works in the WP sandboxes, but in the Vite ones, it throws the above error. If I replace with an absolute path, it works fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure I'm understanding all the path magic here, but the stories look great!!
Issue:
https://linear.app/chromaui/issue/SB-586/core-features-loaders-parameters-decorators
What I did
lib/store
storiesWhat I didn't do
renderers/X
. That can happen as part of removing the examples they are defined in.lib/store
features (e.g. args, export order, titles, etc) , will do in a second PR.