Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Improve generate-repros-next #19001

Merged
merged 6 commits into from
Aug 23, 2022
Merged

Build: Improve generate-repros-next #19001

merged 6 commits into from
Aug 23, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 23, 2022 •
edited
Loading

Issue: N/A

What I did

  • Fix the generate-repros-next to run once & exit properly
  • Misc fixes (see commit descriptions)

Self-merging @ndelangen @yannbf

How to test

  • CI passes

@shilman shilman added the maintenance User-facing maintenance tasks label Aug 23, 2022
@shilman shilman merged commit 6ec7732 into next Aug 23, 2022
@shilman shilman deleted the shilman/improve-generate-repros branch August 23, 2022 10:07
yannbf
yannbf approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @yannbf