fix(clipboard): try to fix clipboard issue #18999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylegach
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Looks good, @Nxtivision! Thanks for taking the time to fix this issue!
|
Hello ! Do you have an idea when this PR will be released ? 🙂 |
|
Should be good to merge as-is! Sorry for the late merge @Nxtivision , thanks again for contributing! |
|
Hello, Is it possible to cherry-pick this PR to the next patch version of 6.5 ? 😄 Because my team is not ready for v7 and we use a lot of referenced Storybook with Chromatic and Nx. Or a possible workaround until v7 is stable ? have a nice day ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16642
What I did
I just added the property allow clipboard-write (according to the doc) on the iframe responsible to display the Source Code, so the user can copy.
How to test
I'm not sure how to test it. We need two storybook with composition using chromatic to see if it works or not. However, this small fix should not destroy all Storybook :)
If your answer is yes to any of these, please make sure to include it in your PR.