Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Move write/read package json into JsPackageManager #18942

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Aug 16, 2022

Issue: N/A

What I did

as title says

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

Sorry, something went wrong.

@yannbf yannbf added the maintenance User-facing maintenance tasks label Aug 16, 2022
@yannbf yannbf force-pushed the feat/improved-package-manager branch from 85a38f1 to 77bf613 Compare August 16, 2022 08:37
@shilman shilman changed the title refactor: move write/read package json into JsPackageManager CLI: Move write/read package json into JsPackageManager Aug 17, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit 693da55 into next Aug 17, 2022
@shilman shilman deleted the feat/improved-package-manager branch August 17, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants