Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a set of test components in addon stories #18825

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Use a set of test components in addon stories #18825

merged 2 commits into from
Aug 2, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Aug 1, 2022 •
edited
Loading

Telescoping on #18824

Issue: https://linear.app/chromaui/issue/SB-570/copy-in-the-generic-stories-based-on-chosen-addons-make-them-work-in

What I did

  • Use globals.Components to drive generic stories
  • Add globals.Components via symlinked (JS-only) template/components directory inside each renderer.

image

image

How to test

yarn example --framework react --force-delete

@tmeasday tmeasday added the maintenance User-facing maintenance tasks label Aug 1, 2022
@tmeasday tmeasday requested review from shilman and ndelangen August 1, 2022 00:43
@tmeasday tmeasday changed the base branch from next to tom/sb-581-copy-in-the-rendererframework-specific August 1, 2022 00:43
tmeasday
tmeasday commented Aug 1, 2022
View reviewed changes
scripts/example.ts Outdated Show resolved Hide resolved
@tmeasday tmeasday changed the title Copy example stories over from renderer + addons Use a set of test components in addon stories Aug 1, 2022
@tmeasday tmeasday mentioned this pull request Aug 1, 2022
Merged
@tmeasday tmeasday force-pushed the tom/sb-581-copy-in-the-rendererframework-specific branch from 57060ea to 9495ec0 Compare August 1, 2022 12:57
@tmeasday tmeasday force-pushed the tom/sb-570-copy-in-the-generic-stories-based-on branch from 770188d to 55b8f56 Compare August 1, 2022 13:39
@tmeasday tmeasday force-pushed the tom/sb-581-copy-in-the-rendererframework-specific branch from 9495ec0 to d4e108f Compare August 1, 2022 22:35
@tmeasday tmeasday force-pushed the tom/sb-570-copy-in-the-generic-stories-based-on branch from 55b8f56 to 4dba874 Compare August 1, 2022 22:54
Base automatically changed from tom/sb-581-copy-in-the-rendererframework-specific to next August 2, 2022 01:04
@tmeasday tmeasday merged commit bdc9137 into next Aug 2, 2022
@tmeasday tmeasday deleted the tom/sb-570-copy-in-the-generic-stories-based-on branch August 2, 2022 04:00
@tmeasday
Copy link
Member Author

tmeasday commented Aug 2, 2022

Self merging @shilman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman left review comments

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees

@yannbf yannbf

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmeasday @shilman @yannbf @ndelangen