-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1699 Have Stories on each level of hierarchy #1763
1699 Have Stories on each level of hierarchy #1763
Conversation
Codecov Report
@@ Coverage Diff @@
## release/3.3 #1763 +/- ##
===============================================
- Coverage 23.12% 23.01% -0.12%
===============================================
Files 253 253
Lines 5755 5731 -24
Branches 687 682 -5
===============================================
- Hits 1331 1319 -12
+ Misses 3935 3919 -16
- Partials 489 493 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks good to me.
I tested:
cra-kitchen-sink: ✅
vue-kitchen-sink: ✅ (temp edited a story)
react-native-vanilla: ✅ (temp edited a story)
All examples kinda need some reorganising, for sure. But that's out of scope for this PR.
I'm super impressed by how fast you made this happen @igor-dv ! 💥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue: #1699
What I did
Fix #1699