-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbars: Fall back to name if both title and icon are not specified #17430
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4192168. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
3d03ed6
to
7cc7274
Compare
@huyenltnguyen could you update this PR? I would do it, but I don't have authorization to commit to your fork. Please merge in the base branch @yannbf could you review as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chromatic borked for a second but I updated the branch and it's all good now. Seems like a great change. Thank you so much for that @huyenltnguyen !
Toolbars: Fall back to name if both title and icon are not specified
Issue: #15259
What I did
name
as the fallback for toolbar title if bothicon
andtitle
are not specified inglobalTypes
. I also added a warning to the console to let the users know how to update their code.showName
is set totrue
. This is related to this change where we deprecated theshowName
config.How to test
Tested with
examples/cra-ts-essentials
.Screenshot
When both
icon
andtitle
are not specifiedBrowser console:
When
showName
is set totrue
Browser console: