Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed empty array, since webpack 2 doesn't support them anymore. #1381

Merged
merged 2 commits into from
Jul 4, 2017

Conversation

Gongreg
Copy link
Member

@Gongreg Gongreg commented Jun 29, 2017

Issue: Couldn't start RN storybook with Production environment.

What I did

Removed empty array, since that was breaking webpack.

How to test

https://github.com/wix/storybook-server - Try to run npm run start.

@storybookbot
Copy link
Collaborator

storybookbot commented Jun 29, 2017

Fails
🚫

PR is not labeled with one of: ["cleanup","breaking","feature","bug","documentation","maintenance","greenkeeper","other"]

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Jun 29, 2017

Codecov Report

Merging #1381 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1381      +/-   ##
==========================================
+ Coverage   14.35%   14.35%   +<.01%     
==========================================
  Files         201      201              
  Lines        4613     4612       -1     
  Branches      506      587      +81     
==========================================
  Hits          662      662              
+ Misses       3510     3458      -52     
- Partials      441      492      +51
Impacted Files Coverage Δ
...ct-native/src/server/config/webpack.config.prod.js 0% <ø> (ø) ⬆️
addons/knobs/src/components/types/Number.js 8.06% <0%> (ø) ⬆️
app/react/src/server/babel_config.js 44.82% <0%> (ø) ⬆️
addons/knobs/src/components/types/Select.js 7.93% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/WrapStory.js 12% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
app/react/src/server/build.js 0% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6df3dea...98f95d7. Read the comment docs.

Copy link
Member

@danielduan danielduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean!

@ndelangen ndelangen added maintenance User-facing maintenance tasks configuration babel / webpack labels Jul 4, 2017
@ndelangen
Copy link
Member

Looks clean, is this breaking in any way?

@ndelangen ndelangen merged commit 89c5f3b into master Jul 4, 2017
@ndelangen ndelangen deleted the fix-rn-webpack-prod-config branch July 4, 2017 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants