Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid prop 'node.type' supplied to 'Props' #1351

Merged

Conversation

thomasbertet
Copy link
Contributor

Issue: #1307

What I did

  • Use the PropTypes.node directly instead of specifying specific node & type key.

How to test

  • Switch to current master branch
  • Launch storybook of examples/cra-kitchen-sink, go to Button >> with some infos.
  • Check the console, it displays the message: Warning: Failed prop type: Invalid prop node.typesupplied toProps, expected a ReactNode

Now switch to this branch, launch storybook & display the same story.

  • No warning should be visible in the console.

Let me know if you need anything else !

@codecov
Copy link

codecov bot commented Jun 23, 2017

Codecov Report

Merging #1351 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1351   +/-   ##
=======================================
  Coverage   13.75%   13.75%           
=======================================
  Files         202      202           
  Lines        4623     4623           
  Branches      509      506    -3     
=======================================
  Hits          636      636           
- Misses       3543     3554   +11     
+ Partials      444      433   -11
Impacted Files Coverage Δ
addons/info/src/components/Props.js 0% <ø> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
lib/ui/src/modules/ui/routes.js 0% <0%> (ø) ⬆️
app/react/src/server/build.js 0% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
app/react/src/client/preview/client_api.js 39.28% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/down_panel.js 23.52% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/handle_routing.js 28.94% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb1bd8b...51f4c9d. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested. @adamdonahue can you comment on this, or @ndelangen since you merged #1245?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants