Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack2 support by changing the use of OccurenceOrderPlugin. #397

Merged
merged 1 commit into from
Aug 23, 2016

Conversation

arunoda
Copy link
Member

@arunoda arunoda commented Aug 23, 2016

Fixes: #396, #248

Stil storybook comes with Webpack 1. But it's possible to use webpack2 if your project use Webpack2.

Here we simply try to use the OccurenceOrderPlugin in both Webpack2 and Webpack1 in the way they exists.

@arunoda arunoda merged commit c938468 into master Aug 23, 2016
@arunoda arunoda deleted the webpack2-support branch August 23, 2016 09:34
@kevinSuttle
Copy link
Contributor

@arunoda How does this affect the current setup?

Right now, I've patched it locally as my top-level config is Webpack 2, and my Storyboard config consists of this line (notice the function call at the end):

module.exports = require('../webpack.config.js')();

@arunoda
Copy link
Member Author

arunoda commented Aug 24, 2016

This is just not a big change. But we simply add compatibility for both Webpack2 and Webpack1.

Not exactly sure about what you asked. But it should work without any issues.

@sheerun sheerun mentioned this pull request Oct 18, 2016
@shilman shilman added the misc label May 27, 2017
Copy link

nx-cloud bot commented Sep 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit defd339. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants