Fix for test-cra was breaking the build #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
force-pushed
the
fix-examples-failingbuild
branch
2 times, most recently
from
034b1ee to
cdb29d2
Compare
…t managed by lerna.
ndelangen
force-pushed
the
fix-examples-failingbuild
branch
from
cdb29d2 to
205b0f8
Compare
Codecov Report
@@ Coverage Diff @@
## master #972 +/- ##
=========================================
Coverage ? 26.88%
=========================================
Files ? 192
Lines ? 4375
Branches ? 700
=========================================
Hits ? 1176
Misses ? 3199
Partials ? 0Continue to review full report at Codecov.
|
ndelangen
changed the title
ndelangen
added
cleanup
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8f36abf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: -none-
What I did
FIX for test-cra which was breaking the build,
because it’s dependencies are not managed by lerna.