Preview hooks: trigger effects after story render #7791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. |
Hypnosphi
requested review from
alterx,
danielduan,
igor-dv,
thomasbertet,
tmeasday and
usulpro
as code owners
Hypnosphi
force-pushed
the
trigger-effects-after-render
branch
from
12a30c7 to
149ceba
Compare
4 tasks
shilman
reviewed
Aug 18, 2019
| @@ -226,8 +226,10 @@ export default function start(render, { decorateStory } = {}) { | |||
| case 'story': | |||
| default: { | |||
| if (getDecorated) { | |||
| render(renderContext); | |||
| addons.getChannel().emit(Events.STORY_RENDERED, id); | |||
| (async () => { | |||
There was a problem hiding this comment.
What should be the handler? logger.error?
There was a problem hiding this comment.
I can't find a way to pass error callback to ReactDOM.render which is the only source of asynchrony here.
Looks like they just use then without catch: https://github.com/facebook/react/blob/master/packages/react-dom/src/client/ReactDOM.js#L393
So we won't actually catch anything. Hopefully, that means that React does the error handling for us
ndelangen
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #7786 (comment) doesn't work because the effects are triggered too early, before the story is rendered
This also addresses #7407 (comment)