Fix addons panel when using preact #3882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanpoChew
requested review from
Hypnosphi,
ndelangen and
tmeasday
as code owners
|
Useful thanks! Do you think you could resolve the minor lint issue? |
Codecov Report
@@ Coverage Diff @@
## master #3882 +/- ##
==========================================
+ Coverage 41.44% 41.45% +0.01%
==========================================
Files 455 455
Lines 5193 5194 +1
Branches 903 904 +1
==========================================
+ Hits 2152 2153 +1
Misses 2496 2496
Partials 545 545
Continue to review full report at Codecov.
|
|
@ndelangen done 👍 |
ndelangen
added
the
patch:yes
danielduan
approved these changes
Jul 17, 2018
|
Great work @sanpoChew! Thank you so much! |
Hypnosphi
removed
the
patch:yes
|
@ndelangen please only add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Addons such as knobs were no longer rendering in the addon panel after installing the latest alpha, stemming from the changes in this merge request: #3628. This is due to children in preact always being an Array.
What I did
use Array.isArray to to check if content is an array, pull out the first value if it is.
How to test
Is this testable with Jest or Chromatic screenshots?
Nope.
Does this need a new example in the kitchen sink apps?
Nope.
Does this need an update to the documentation?
Nope.