-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use react-dev-utils@next #3852
Use react-dev-utils@next #3852
Conversation
@pelotom
|
@ndelangen I'm not really familiar with the dev workflow for this project... I ran
and all tests pass, but when I try to run
I get
even though |
app/react-native/package.json
Outdated
@@ -29,7 +29,7 @@ | |||
"@storybook/channel-websocket": "4.0.0-alpha.12", | |||
"@storybook/core": "4.0.0-alpha.12", | |||
"@storybook/core-events": "4.0.0-alpha.12", | |||
"@storybook/react-dev-utils": "^5.0.0", | |||
"react-dev-utils": "next", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use the version number instead of relying on the next
tag. I think we're looking for react-dev-utils@^6.0.0-next.3e165448
. the next
version could easily be an alpha of 7.0.0-x
in the future and cause unintended changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use actual version number
Codecov Report
@@ Coverage Diff @@
## master #3852 +/- ##
=======================================
Coverage 41.56% 41.56%
=======================================
Files 455 455
Lines 5177 5177
Branches 899 899
=======================================
Hits 2152 2152
Misses 2485 2485
Partials 540 540
Continue to review full report at Codecov.
|
@danielduan do your approve? |
Thank you very much @pelotom! |
Recently
create-react-app
published a new version ofreact-dev-utils
on thenext
tag, which I believe should obviate the need for the@storybook/react-dev-utils
fork. This reverts #3312 and instead makes storybook depend onreact-dev-utils@next
.