Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Disable Angular 15 sandbox #24358

Merged
merged 1 commit into from
Oct 3, 2023
Merged

CI: Disable Angular 15 sandbox #24358

merged 1 commit into from
Oct 3, 2023

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Oct 3, 2023

What I did

Disabled Angular 15 sandbox is CI as it is currently failing and blocking everyone.

Checklist for Contributors

Testing

Daily CI workflow should not fail.

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@JReinhold JReinhold added angular build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. labels Oct 3, 2023
@JReinhold JReinhold self-assigned this Oct 3, 2023
@JReinhold JReinhold merged commit e8ca10c into next Oct 3, 2023
15 of 22 checks passed
@JReinhold JReinhold deleted the disable-angular-15-sandbox branch October 3, 2023 11:52
@github-actions github-actions bot mentioned this pull request Oct 3, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants