Vite: Do not pre-bundle @vitejs/plugin-vue #20787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #20583
What I did
Reverts #20343. This package is not bundle-able, due to its use of
import.meta.env
here: https://github.com/vitejs/vite-plugin-vue/blob/eef8929c95d8b5cce1385a1d5e60da56a8420c0b/packages/plugin-vue/src/compiler.ts#L27. See evanw/esbuild#2249 for some explanation of why this is not able to be bundled.I don't know what exact situation #20343 was attempting to fix, but presumably that will start to be a problem again. I think we can live with it if it's just a version conflict warning.
How to test
Create a vue3 sandbox, delete the
vite.config.js
file, start storybook. Previously it would crash, and now it should work fine.Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]