Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite: Do not pre-bundle @vitejs/plugin-vue #20787

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Jan 25, 2023

Issue: #20583

What I did

Reverts #20343. This package is not bundle-able, due to its use of import.meta.env here: https://github.com/vitejs/vite-plugin-vue/blob/eef8929c95d8b5cce1385a1d5e60da56a8420c0b/packages/plugin-vue/src/compiler.ts#L27. See evanw/esbuild#2249 for some explanation of why this is not able to be bundled.

I don't know what exact situation #20343 was attempting to fix, but presumably that will start to be a problem again. I think we can live with it if it's just a version conflict warning.

How to test

Create a vue3 sandbox, delete the vite.config.js file, start storybook. Previously it would crash, and now it should work fine.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen ndelangen merged commit 9167aa0 into next Jan 26, 2023
@ndelangen ndelangen deleted the vite/vue3-no-config branch January 26, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants