Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Allow creating internal templates that extend others and pass main.js options #20054

Merged
merged 14 commits into from
Jan 12, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Dec 2, 2022

This PR introduces the following changes:

  1. The ability to add custom mainJs in repro-templates
  2. Repro templates are separated in two sections: baseTemplates and internalTemplates.
    Internal templates reuse existing templates from baseTemplates, and add extra functionality on top, such as, having a custom mainJs with storyStoreV7: false so we can test storyStoreV6 configurations. Those internal templates have to have an id that starts with internal/ so they are grouped in the repro-sandboxes repo
  3. Some QoL improvements for the repro command

The idea is to allow us to test more specific configurations, such as storyStoreV6.

This is still a WIP (types are broken the files I modified).

This PR allows two things in repro templates:

1. A template.mainConfig field that gets written to the main.js (this is a pretty simple change).
2. The ability for one template to extend another.

The second part is needed for the first, otherwise we'll end up creating duplicate repros for templates that differ only in configs. (Possibly we should just live with that in the short term?!?)

Works but there are typing problems
@tmeasday tmeasday added the build Internal-facing build tooling & test updates label Dec 2, 2022
@yannbf yannbf added the ci:merged Run the CI jobs that normally run when merged. label Jan 11, 2023
@yannbf yannbf changed the title Allow creating templates that extend others and pass main.js options Build: Allow creating internal templates that extend others and pass main.js options Jan 12, 2023
@yannbf yannbf merged commit e465ca4 into next Jan 12, 2023
@yannbf yannbf deleted the tom/sb-1040-allow-creating-templates-that-augment branch January 12, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:merged Run the CI jobs that normally run when merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants