-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Allow creating internal templates that extend others and pass main.js
options
#20054
Merged
yannbf
merged 14 commits into
next
from
tom/sb-1040-allow-creating-templates-that-augment
Jan 12, 2023
Merged
Build: Allow creating internal templates that extend others and pass main.js
options
#20054
yannbf
merged 14 commits into
next
from
tom/sb-1040-allow-creating-templates-that-augment
Jan 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works but there are typing problems
yannbf
approved these changes
Jan 12, 2023
yannbf
changed the title
Allow creating templates that extend others and pass
Build: Allow creating internal templates that extend others and pass Jan 12, 2023
main.js
optionsmain.js
options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
mainJs
in repro-templatesbaseTemplates
andinternalTemplates
.Internal templates reuse existing templates from
baseTemplates
, and add extra functionality on top, such as, having a custom mainJs withstoryStoreV7: false
so we can test storyStoreV6 configurations. Those internal templates have to have an id that starts withinternal/
so they are grouped in therepro-sandboxes
repoThe idea is to allow us to test more specific configurations, such as storyStoreV6.
This is still a WIP (types are broken the files I modified).This PR allows two things in repro templates:1. Atemplate.mainConfig
field that gets written to themain.js
(this is a pretty simple change).2. The ability for one template to extend another.The second part is needed for the first, otherwise we'll end up creating duplicate repros for templates that differ only in configs. (Possibly we should just live with that in the short term?!?)