Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Improved error checking in global addDecorator" #1716

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Aug 23, 2017

Related to the #1637

@igor-dv igor-dv added the bug label Aug 23, 2017
Copy link
Member

@Hypnosphi Hypnosphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 23, 2017

Codecov Report

Merging #1716 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1716      +/-   ##
==========================================
- Coverage   21.23%   21.18%   -0.06%     
==========================================
  Files         252      252              
  Lines        5698     5694       -4     
  Branches      680      689       +9     
==========================================
- Hits         1210     1206       -4     
+ Misses       3975     3954      -21     
- Partials      513      534      +21
Impacted Files Coverage Δ
app/react/src/client/preview/client_api.js 87.5% <ø> (-1.14%) ⬇️
app/react/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/react/src/server/babel_config.js 0% <0%> (-83.88%) ⬇️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
addons/knobs/src/KnobManager.js 32% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
addons/knobs/src/components/types/Color.js 8% <0%> (ø) ⬆️
addons/info/src/components/PropVal.js 43.15% <0%> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ee5038...743fb3b. Read the comment docs.

@ndelangen ndelangen merged commit 6f7d8f3 into master Aug 23, 2017
@ndelangen ndelangen deleted the revert-1481-fixes-877 branch August 23, 2017 12:59
@igor-dv
Copy link
Member Author

igor-dv commented Aug 23, 2017

Wow, that was fast !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants