Upgrade react-native-compat to avoid PropTypes warnings #1673
Conversation
atticoos
changed the title
app/react-native/package.json
Outdated
| @@ -56,7 +56,7 @@ | |||
| "json-loader": "^0.5.4", | |||
| "json5": "^0.5.1", | |||
| "postcss-loader": "^2.0.5", | |||
| "react-native-compat": "0.0.2", | |||
| "react-native-compat": "0.0.4", | |||
There was a problem hiding this comment.
do you plan on versioning according to semvar? we could do ~0.0.4 so we don't have to do a PR for every minor fix.
There was a problem hiding this comment.
Yes - this is currently in a prerelease stage so we'd need to upgrade to 1.x for precedence options (unless that has since changed)
Let me update react-native-compat to 1.0.0 so we can take advantage of ~
There was a problem hiding this comment.
Any strong opinions on tilde vs caret? I generally go with a tilde, but given the pattern of this package file, I added a caret.
There was a problem hiding this comment.
Think it really depends on how you plan to maintain it. Automatic updates should not be breaking changes. Typically ^ minor version updates are feature improvements, ~ are bug fixes. If you follow the same convention, ^ should be fine.
There was a problem hiding this comment.
The project is semver compliant 👍
atticoos
force-pushed
the
latest-react-native-compat
branch
from
950858f to
5e9f42f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1673 +/- ##
=========================================
Coverage ? 21.13%
=========================================
Files ? 247
Lines ? 5582
Branches ? 671
=========================================
Hits ? 1180
Misses ? 3917
Partials ? 485Continue to review full report at Codecov.
|
One step towards #1540 by updating the
react-native-compatdependency to move off ofReact.PropTypes(atticoos/react-native-compat#1). There still needs to be a greater sweep to remove usages ofReact.PropTypes-- users will likely still see this warning on their devices.What I did
Upgrades to
[email protected], which usesprop-types.How to test
I manually pulled down
react-native-compatand compared the old vs new version to confirm the warning goes away. However, as mentioned, that may not entirely fix the warnings throughout Storybook we still have occurrences using it).