-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix react native example and bootstrapping #1514
Conversation
lib/addons/src/index.js
Outdated
export class AddonStore { | ||
constructor() { | ||
this.loaders = {}; | ||
this.panels = {}; | ||
// this.channel should get overwritten by setChannel if package versions are | ||
// correct and AddonStore is a proper singleton. If not, throw an error. | ||
this.channel = { on: channelError, emit: channelError }; | ||
this.channel = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was good whilst it lasted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It wasn't good! It wasted multiple hours of my time! 😭
Codecov Report
@@ Coverage Diff @@
## master #1514 +/- ##
==========================================
+ Coverage 14.6% 14.61% +<.01%
==========================================
Files 202 202
Lines 4655 4653 -2
Branches 521 522 +1
==========================================
Hits 680 680
+ Misses 3513 3509 -4
- Partials 462 464 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the bootstrapping bit, but good with removing the check.
An alternative approach: #1515 |
Issue: #1509
What I did
Addresses issues raised in #1509:
How to test