Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controls: QA fixes for Object and Color controls #14392

Merged
merged 3 commits into from
Mar 30, 2021
Merged

Controls: QA fixes for Object and Color controls #14392

merged 3 commits into from
Mar 30, 2021

Conversation

ghengeveld
Copy link
Member

Issue: #14374

What I did

  • Hide the RAW toggle when data isn't representable in the JSON tree
  • Fixed NaNNaNNaN color value when adjusting hue on invalid value
  • Fixed color presets to not list invalid initial value

How to test

  • Is this testable with Jest or Chromatic screenshots? no
  • Does this need a new example in the kitchen sink apps? no
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

@ghengeveld ghengeveld requested review from shilman and yannbf March 30, 2021 08:26
@ghengeveld ghengeveld changed the title QA fixes for Object and Color controls Controls: QA fixes for Object and Color controls Mar 30, 2021
@ghengeveld ghengeveld mentioned this pull request Mar 30, 2021
Closed
shilman
shilman approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@shilman shilman merged commit 44eca58 into next Mar 30, 2021
@shilman shilman deleted the fix-raw-toggle branch March 30, 2021 10:11
@yannbf
Copy link
Member

yannbf commented Mar 30, 2021

Man you're fast!!

@BoxPistols BoxPistols mentioned this pull request Feb 20, 2022
Open
This was referenced Sep 20, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 24, 2023
Open
Open
This was referenced Mar 22, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@lili2311 lili2311 mentioned this pull request Apr 21, 2024
Open
This was referenced May 20, 2024
Open
Open
Open
Open
This was referenced Sep 17, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@yannbf yannbf Awaiting requested review from yannbf

@ndelangen ndelangen Awaiting requested review from ndelangen

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees
No one assigned
Labels
addon: controls bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghengeveld @yannbf @shilman