Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Fix CSS for IE11 #13159

Merged
merged 2 commits into from
Nov 18, 2020
Merged

UI: Fix CSS for IE11 #13159

merged 2 commits into from
Nov 18, 2020

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Nov 18, 2020 •
edited
Loading

Issue: #12386

What I did

This fixes vertical centering in IE11 when using layout: "centered". It also replaces 8-digit hex color values with transparentize, because IE11 doesn't support this notation.

I used Browserstack to test this.

How to test

  • Is this testable with Jest or Chromatic screenshots? Yes, but we don't test against IE right now.
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

@ghengeveld ghengeveld requested a review from ndelangen November 18, 2020 16:10
@ghengeveld ghengeveld changed the title CSS fixes for IE11 UI: Fix CSS for IE11 Nov 18, 2020
shilman
shilman approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman added this to the 6.1 core milestone Nov 18, 2020
@shilman shilman merged commit 45ddc0c into next Nov 18, 2020
@shilman shilman deleted the 12386-ie11-layout-centered branch November 18, 2020 18:22
@shilman shilman mentioned this pull request Nov 18, 2020
Closed
@lili2311 lili2311 mentioned this pull request Sep 20, 2023
Open
@lili2311 lili2311 mentioned this pull request Nov 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

@alterx alterx Awaiting requested review from alterx

@igor-dv igor-dv Awaiting requested review from igor-dv

@tmeasday tmeasday Awaiting requested review from tmeasday

Assignees

@ndelangen ndelangen

Labels
bug ie11 ui
Projects
None yet
Milestone
6.1 core
Development

Successfully merging this pull request may close these issues.
3 participants
@ghengeveld @shilman @ndelangen