-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated issue triage guidelines #1024
Conversation
@shilman I think this branch is messed up, I don't see any changes |
@tmeasday sorry my bad. fixed! |
Codecov Report
@@ Coverage Diff @@
## master #1024 +/- ##
=========================================
Coverage ? 12.51%
=========================================
Files ? 196
Lines ? 4458
Branches ? 713
=========================================
Hits ? 558
Misses ? 3269
Partials ? 631 Continue to review full report at Codecov.
|
Looks good--want to add a description of what |
Once you've helped out on a few issues, if you'd like triage access you can help label issues and respond to reporters. | ||
|
||
We use the following label scheme to categorize issues: | ||
- **type** - `bug`, `feature`, `question / support`, `discussion`, `greenkeeper`, `maintenance`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a label feature / change request
might be more descriptive.
CONTRIBUTING.md
Outdated
@@ -111,13 +120,12 @@ If an issue is a `bug`, and it doesn't have a clear reproduction that you have p | |||
|
|||
- `bug`s should be closed when the issue is fixed and merged to `master` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merged to master or released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think merged myself. Otherwise we need another label fixed
or the like and we mentally have to ignore fixed
issues. I appreciate users might not find an issue that has been closed but not yet released however.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although maybe it's easier for us to ignore fixed
issues, and we can use them to construct a meaningful changelog. I change my vote ;)
Good work! |
Could we add a description or clarify use cases for labels:
does One more not related to this PR but possible worth to discuss. Should we ask people to add [prefix] with area/type label when they submitting an issue/PR since they can't add labels themselves? |
@usulpro Those are all great points. I'm going to merge this now and will follow up on the status-related labels in a separate PR. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 674d6e2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Issue: #733
What I did
@tmeasday and I sat down and reworked the issue labels in the Storybooks repo. This change summarizes the changes we made. Separately we will propose some guidelines around closing issues that have gone stale, etc.
How to test
N/A