Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Textarea does not have a height or maxHeight #9849

Closed
Raphe-dev opened this issue Feb 13, 2020 · 3 comments
Closed

Form Textarea does not have a height or maxHeight #9849

Raphe-dev opened this issue Feb 13, 2020 · 3 comments

Comments

@Raphe-dev
Copy link
Contributor

Raphe-dev commented Feb 13, 2020

Describe the bug
Textarea in Knobs addon does not have a height, which makes a huge text area when passing big arrays.

To Reproduce
Create a object or text knobs and pass a big array of data to it.

Expected behavior
Maybe a 10 or 20 line default height would be great (200 - 400px according to hardcoded line-height).

Code snippets
/lib/components/src/form/input/input.tsx line148
I'm not used to TypeScript but I believe adding a height : 200 at this line would solve this.
Or maybe it would just make all textarea 200px by default no matter the content?
If so maybe a maxHeight of 400 - 600 would be good anyway it does not make sense to be bigger than that does it?

System:

System:
OS: Linux 5.3 Ubuntu 18.04.4 LTS (Bionic Beaver)
CPU: (4) x64 Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz
Binaries:
Node: 12.15.0 - /usr/bin/node
npm: 6.13.4 - /usr/bin/npm
Browsers:
Chrome: 80.0.3987.87
Firefox: 72.0.2
npmPackages:
@storybook/addon-actions: ^5.3.12 => 5.3.12
@storybook/addon-knobs: ^5.3.12 => 5.3.12
@storybook/addon-links: ^5.3.12 => 5.3.12
@storybook/addon-viewport: ^5.3.12 => 5.3.12
@storybook/addons: ^5.3.12 => 5.3.12
@storybook/vue: ^5.3.12 => 5.3.12

I know there was an issue about that in the near past that the bot closed ( Issue 8192 ) but I believe this is a simple fix that would benefit all big data knobs users

@shilman
Copy link
Member

shilman commented Feb 14, 2020

@Raphe-dev Thanks, that makes sense! Any interest in contributing a small PR for this?

@stale
Copy link

stale bot commented Mar 6, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Mar 6, 2020
@stale
Copy link

stale bot commented Apr 5, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Apr 5, 2020
@shilman shilman removed the inactive label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants