Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow meta viewport tag to be customised #9776

Closed
karl opened this issue Feb 6, 2020 · 8 comments
Closed

Allow meta viewport tag to be customised #9776

karl opened this issue Feb 6, 2020 · 8 comments

Comments

@karl
Copy link
Contributor

karl commented Feb 6, 2020

Bug or support request summary

We have an existing website that we are adding React components to. The website has a viewport tag with the initial scale set to 0.6:

<meta name="viewport" content="width=device-width, initial-scale=0.6">

We would like to set Storybook to use the same initial-scale value so that components rendered there appear the same size as they will on the website.

We've tried adding a viewport tag to preview-head.html but the browser (Chrome) seems to ignore it in favour of the one that Storybook defines above it in the document head.

It would be great if we had the option of replacing the meta viewport tag without our own one.

  • @storybook/react 5.3.9

Affected platforms

  • Chrome on macOS running using the devtools to run as an iPhone 6 device.
@stale
Copy link

stale bot commented Feb 28, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Feb 28, 2020
@shilman shilman added the core label Feb 28, 2020
@stale stale bot removed the inactive label Feb 28, 2020
@stale
Copy link

stale bot commented Mar 20, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Mar 20, 2020
@stale stale bot removed the inactive label Mar 21, 2020
@christopherhafke
Copy link
Contributor

Hi, @eashwar and I are interested in working on this as first-time contributors. Could we take this one?

@shilman
Copy link
Member

shilman commented Apr 2, 2020

@christopherhafke absolutely! contributions always welcome!

@christopherhafke
Copy link
Contributor

Unfortunately, due to our schedules, I don't think we're going to be able to work on this issue, and we didn't want to prevent others from tackling it. Sorry about that!

@stale
Copy link

stale bot commented May 9, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label May 9, 2020
@stale
Copy link

stale bot commented Jun 9, 2020

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@krutoo
Copy link

krutoo commented Dec 8, 2023

@shilman is it possible now to change default meta tags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants