Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show storyshots in UI #878

Closed
shilman opened this issue Apr 15, 2017 · 3 comments
Closed

Show storyshots in UI #878

shilman opened this issue Apr 15, 2017 · 3 comments

Comments

@shilman
Copy link
Member

shilman commented Apr 15, 2017

Issue by SpaceK33z
Tuesday Dec 06, 2016 at 11:12 GMT
Originally opened as storybook-eol/storyshots#60


It would be great if the storyshot tests were visible in the Storybook UI, like storybook-addon-specifications. At the moment the storyshots are not in the same "development flow", because you have to open your terminal each time to see the storyshots.

A next step would be to have a button you can click to update the storyshot if it failed.

I might be able to work on this during the holidays. Just to start of the discussion, how could I implement this (roughly)?

The current idea I have is to hook into the Storybook server (which should be possible since #435) and install a WebSocket. Storyshots would use this WebSocket to push the failed / successful storyshots. On the client, there is storybook-channel-websocket to listen / push things to the WebSocket.

Or would it be cleaner to make a separate addon for this? I think all storyshots users would want this, so that's why I'm leaning towards adding it in storyshots at the moment.

@ndelangen
Copy link
Member

@stale
Copy link

stale bot commented Nov 27, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Nov 27, 2017
@stale
Copy link

stale bot commented Dec 12, 2017

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

@stale stale bot closed this as completed Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants