You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be great if the storyshot tests were visible in the Storybook UI, like storybook-addon-specifications. At the moment the storyshots are not in the same "development flow", because you have to open your terminal each time to see the storyshots.
A next step would be to have a button you can click to update the storyshot if it failed.
I might be able to work on this during the holidays. Just to start of the discussion, how could I implement this (roughly)?
The current idea I have is to hook into the Storybook server (which should be possible since #435) and install a WebSocket. Storyshots would use this WebSocket to push the failed / successful storyshots. On the client, there is storybook-channel-websocket to listen / push things to the WebSocket.
Or would it be cleaner to make a separate addon for this? I think all storyshots users would want this, so that's why I'm leaning towards adding it in storyshots at the moment.
The text was updated successfully, but these errors were encountered:
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!
Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!
Issue by SpaceK33z
Tuesday Dec 06, 2016 at 11:12 GMT
Originally opened as storybook-eol/storyshots#60
It would be great if the storyshot tests were visible in the Storybook UI, like storybook-addon-specifications. At the moment the storyshots are not in the same "development flow", because you have to open your terminal each time to see the storyshots.
A next step would be to have a button you can click to update the storyshot if it failed.
I might be able to work on this during the holidays. Just to start of the discussion, how could I implement this (roughly)?
The current idea I have is to hook into the Storybook server (which should be possible since #435) and install a WebSocket. Storyshots would use this WebSocket to push the failed / successful storyshots. On the client, there is storybook-channel-websocket to listen / push things to the WebSocket.
Or would it be cleaner to make a separate addon for this? I think all storyshots users would want this, so that's why I'm leaning towards adding it in storyshots at the moment.
The text was updated successfully, but these errors were encountered: