Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@storybook/[email protected]" has incorrect peer dependency "@storybook/[email protected] #8634

Closed
Victorien-Tardif opened this issue Oct 30, 2019 · 4 comments

Comments

@Victorien-Tardif
Copy link

Describe the bug
@storybook/[email protected] has incorrect peer dependency declared in package.json:

"@storybook/addon-knobs": "5.2.0-beta.13",

Expected behavior
It should have the peer dependency @storybook/addon-knobs ~5.2.0 or something like that but should not complain if I have @storybook/[email protected] in any case.

@shilman
Copy link
Member

shilman commented Oct 30, 2019

Thanks, will get out the fix in the next patch release!

@shilman
Copy link
Member

shilman commented Nov 1, 2019

Yay!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-alpha.35 containing PR #8643 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Nov 1, 2019
@shilman
Copy link
Member

shilman commented Nov 9, 2019

Olé!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.6 containing PR #8644 that references this issue. Upgrade today to try it out!

@Victorien-Tardif
Copy link
Author

@storybook/[email protected]" has incorrect peer dependency "@storybook/[email protected]"

:/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants