Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Configuration of DocsContent max-width (styles) #8051

Closed
alazurenko opened this issue Sep 11, 2019 · 7 comments
Closed

Addon-docs: Configuration of DocsContent max-width (styles) #8051

alazurenko opened this issue Sep 11, 2019 · 7 comments

Comments

@alazurenko
Copy link
Contributor

Greetings Dear Maintainers,

Is your feature request related to a problem? Please describe.
I'd like to have control over DocsContent width. Currently, it's set to 800px. Is there is a way to change it?

Describe the solution you'd like
I would like to have options to change the width of docs content in configuration/theme to addon docs, so it is set for every story. Even more, there would be nice to have more control over container's styling.

Describe alternatives you've considered
I have tried to use css classes they are being overwritten

Are you able to assist bring the feature to reality?
Yes

@alazurenko
Copy link
Contributor Author

This issue seems to be related to this one.

@shilman
Copy link
Member

shilman commented Sep 11, 2019

Cc @domyen who owns docs theming 🙏

@domyen
Copy link
Member

domyen commented Sep 11, 2019

Hey @alazurenko good idea. We should add a static className to allow you to target it reliably (chatted to @shilman about this just now)

We're unlikely to add this support to the theme explicitly because we want to keep the API small for now.

@alazurenko
Copy link
Contributor Author

Hi @domyen, @shilman
I've create PR #8061 with static css classes.

@shilman
Copy link
Member

shilman commented Sep 24, 2019

Yee-haw!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-alpha.1 containing PR #8061 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Sep 24, 2019
@shilman
Copy link
Member

shilman commented Oct 7, 2019

Jeepers creepers!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.2 containing PR #8061 that references this issue. Upgrade today to try it out!

@alazurenko
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants