Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing event.target causes Storybook to hang #779

Closed
shilman opened this issue Apr 15, 2017 · 2 comments
Closed

Passing event.target causes Storybook to hang #779

shilman opened this issue Apr 15, 2017 · 2 comments

Comments

@shilman
Copy link
Member

shilman commented Apr 15, 2017

Issue by TheSisb
Thursday Jan 19, 2017 at 00:52 GMT
Originally opened as storybook-eol/storybook-addon-actions#27


I have a story that passes onFocus={action('Focused')}
The component is an input element with onFocus={this.onFocus}

onFocus = e => {
  this.props.onFocus && this.props.onFocus(e.target);  // App hangs.  'e' alone is fine.
};
@shilman
Copy link
Member Author

shilman commented Apr 15, 2017

Comment by timoxley
Monday Mar 20, 2017 at 07:04 GMT


Can reproduce. I'm getting incredibly slow responses from action. Click handler takes about a second, and seems to be stuck stringifying an html element:

image

As a quick workaround I suggest the serializer should specifically ignore dom elements.

Why does it need to stringify at all?

@ndelangen
Copy link
Member

I'm going to close this because it's a duplicate of #778, thanks for reporting @TheSisb!

We're looking for a contributor that can make a PR for this, maybe you? or @timoxley ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants