-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addon-knobs Select | Option values as Arrays #7600
Comments
@emilio-martinez assigned you -- hope that's ok! 🙇 |
@shilman sure thing! I'm on it :) |
ping |
@nickofthyme Did this not fix the issue? #7411 |
@shilman No that PR predates this issue. The issue I mentioned in that PR was regarding the This issue is regarding the use of an In the
|
Olé!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-rc.9 containing PR #8027 that references this issue. Upgrade today to try it out! You can find this prerelease on the Closing this issue. Please re-open if you think there's still more to do. |
Describe the bug
As of
v5.1.9
I could use arrays or any custom type as an option value with theselect
knob. This functionality is now not allowed as ofv5.2.0-beta.*
.To Reproduce
Steps to reproduce the behavior:
select
knobv5.2.0-beta.19
there is a type error for the option values as the select option value can only be one of...storybook/addons/knobs/src/components/types/Select.tsx
Line 7 in ec0fcd4
It looks like since
v5.1.9
you upgrade to typescript ( yay! 🎉) but this value restriction causes a breaking change. I wasn't sure to put this as a feature or bug but since it broke my current usage I decided to label it as a bug. Also considering it is allowable to have arrays as values per the latest docs.Expected behavior
Allow a generic type as an option value....
System:
System:
OS: macOS 10.14.5
CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Binaries:
Node: 10.15.2 - ~/.nvm/versions/node/v10.15.2/bin/node
Yarn: 1.16.0 - /usr/local/bin/yarn
npm: 6.9.0
Browsers:
Chrome: 75.0.3770.142
Safari: 12.1.1
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: