Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel config in package.json #754

Closed
ButuzGOL opened this issue Apr 10, 2017 · 8 comments
Closed

babel config in package.json #754

ButuzGOL opened this issue Apr 10, 2017 · 8 comments

Comments

@ButuzGOL
Copy link

No description provided.

@ndelangen
Copy link
Member

ndelangen commented Apr 12, 2017

Hey, thanks for the issue!, Can you please give us more information what is wrong or being requested here?

@ButuzGOL
Copy link
Author

currently storybook takes config only from .babelrc but if i want to keep it in package.json
https://github.com/storybooks/react-storybook/blob/master/src/server/babel_config.js#L51

https://babeljs.io/docs/usage/babelrc/#use-via-package-json

@fczuardi
Copy link

@ndelangen I think this is still an issue and we should reopen this bug.

storybook does not honor babel presets and plugins defined inside package.json (the workaround is to copy that babel config to a different file, and name that file .babelrc)

I think it would be nice if storybook is able to use existing custom babel configs when they are present in the package.json, and I can try to write up a patch if this issue gets reopened.

@ndelangen ndelangen reopened this Oct 24, 2017
@ndelangen
Copy link
Member

Sure, I would be happy to get a PR on this!

Here's where the code is:
https://github.com/storybooks/storybook/blob/master/app/vue/src/server/babel_config.js

(there's similar code for app/vue)

@stale
Copy link

stale bot commented Dec 8, 2017

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 60 days. Thanks!

@stale stale bot added the inactive label Dec 8, 2017
@ndelangen
Copy link
Member

@fczuardi Need help help opening a PR?

@JulianoRodrigues
Copy link

Hey guys, do you still need help with this issue?

@Hypnosphi
Copy link
Member

Released as 4.0.0-alpha.20

@Hypnosphi Hypnosphi reopened this Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants