Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte stores not supported #6904

Closed
tarjei opened this issue May 29, 2019 · 4 comments
Closed

Svelte stores not supported #6904

tarjei opened this issue May 29, 2019 · 4 comments

Comments

@tarjei
Copy link
Contributor

tarjei commented May 29, 2019

Describe the bug
If you define a Svelte component that dependes on a store, you create the component like this:

new MyComponent({target: "#roor", store: store})

The problem is that the Svelte component api (v2) also supports passing in a store value that is unsupported by storybook-svelte.

To Reproduce
Se description above.
Expected behavior
Storybook should also pass the store key to the component.

System:

  • OS: linux

  • Device: desktop

  • Framework: svelte

  • Version:

    • svelte 2.16.1,
    • @storybook/svelte": "^5.0.11"
@shilman
Copy link
Member

shilman commented May 29, 2019

cc @plumpNation @cam-stitt

@stale
Copy link

stale bot commented Jun 19, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jun 19, 2019
@plumpNation
Copy link
Contributor

I'm sorry, I don't have time right now to contribute on this. One thing to be aware of is that there is a lot of work happening to update the svelte version to 3 in storybook. Backward compatibility may not be achieved as there are large breaking changes between svelte 2 and 3.

#7023 (comment)

@stale stale bot removed the inactive label Jun 23, 2019
@cam-stitt
Copy link
Contributor

As @plumpNation said, storybook has moved to support Svelte 3 only as of #6698. It was stated in that PR that it was a "breaking change" as it removed the support for Svelte 2 completely.

@shilman shilman closed this as completed Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants