Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knobs causing re-renders on react native #6679

Closed
bryankang opened this issue Apr 30, 2019 · 6 comments
Closed

Knobs causing re-renders on react native #6679

bryankang opened this issue Apr 30, 2019 · 6 comments

Comments

@bryankang
Copy link

bryankang commented Apr 30, 2019

To reproduce, use react-native and install 5.1.0-alpha.36. Add required dependencies to use react-native-server and register addon-knobs. Use a knob inside a render method and call console.log with something. Build it, run it, debug on browser. You can see that it'll log (implying unnecessary re-renders) every half second or so.

Possibly related to #6675 but no action is required to see the bug I mentioned above.

@stale
Copy link

stale bot commented May 21, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label May 21, 2019
@lyqht
Copy link

lyqht commented May 31, 2019

Any updates to this?
Might be relevant to the issue that I brought up for #6918

@stale stale bot removed the inactive label May 31, 2019
@y-nk
Copy link
Contributor

y-nk commented May 31, 2019

looks to me related to Vue and other frameworks as well :/

@leoyli
Copy link
Contributor

leoyli commented May 31, 2019

It seems a recurrent bug. The above #6705, #6863 all share the same root cause.

This probably would trace back to #6022 PR. Unfortunately, I'm currently busy in my day-time job and would stay focus on migrate @storybook/ui into TS. If anyone would be able to voluntarily help out would much be appreciated. 🙏

Also, I think @ndelangen have some works/explorations on rewriting knobs?

@stale stale bot added the inactive label Jun 21, 2019
@Gongreg Gongreg added the bug label Jul 1, 2019
@stale stale bot removed the inactive label Jul 1, 2019
@stale stale bot added the inactive label Jul 22, 2019
@Gongreg Gongreg removed the inactive label Jul 22, 2019
@storybookjs storybookjs deleted a comment from stale bot Jul 22, 2019
@storybookjs storybookjs deleted a comment from stale bot Jul 22, 2019
@stale
Copy link

stale bot commented Aug 12, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Aug 12, 2019
@stale
Copy link

stale bot commented Sep 11, 2019

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants