-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knobs causing re-renders on react native #6679
Comments
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Any updates to this? |
looks to me related to Vue and other frameworks as well :/ |
It seems a recurrent bug. The above #6705, #6863 all share the same root cause. This probably would trace back to #6022 PR. Unfortunately, I'm currently busy in my day-time job and would stay focus on migrate Also, I think @ndelangen have some works/explorations on rewriting knobs? |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook! |
To reproduce, use
react-native
and install5.1.0-alpha.36
. Add required dependencies to usereact-native-server
and registeraddon-knobs
. Use a knob inside a render method and callconsole.log
with something. Build it, run it, debug on browser. You can see that it'll log (implying unnecessary re-renders) every half second or so.Possibly related to #6675 but no action is required to see the bug I mentioned above.
The text was updated successfully, but these errors were encountered: